Skip to content

MINOR: Narrow remote copy lag validator props to Map<String, ?> and update the upgrade doc for KIP-1241#22363

Open
jiafu1115 wants to merge 7 commits into
apache:trunkfrom
jiafu1115:followupRemoteStorage
Open

MINOR: Narrow remote copy lag validator props to Map<String, ?> and update the upgrade doc for KIP-1241#22363
jiafu1115 wants to merge 7 commits into
apache:trunkfrom
jiafu1115:followupRemoteStorage

Conversation

@jiafu1115
Copy link
Copy Markdown
Contributor

@jiafu1115 jiafu1115 commented May 24, 2026

This is one followup PR for the review:
#20913 (comment) thanks
cc @chia7712

@github-actions github-actions Bot added the triage PRs from the community label May 24, 2026
@jiafu1115 jiafu1115 changed the title MINOR:MINOR: Narrow remote copy lag validator props to Map<String, ?> MINOR: Narrow remote copy lag validator props to Map<String, ?> May 24, 2026
@github-actions github-actions Bot added storage Pull requests that target the storage module small Small PRs labels May 24, 2026
Signed-off-by: Jian <fujian1115@gmail.com>
@jiafu1115 jiafu1115 changed the title MINOR: Narrow remote copy lag validator props to Map<String, ?> MINOR: Narrow remote copy lag validator props to Map<String, ?> and Update the upgrade doc for KIP-1241 May 24, 2026
Signed-off-by: Jian <fujian1115@gmail.com>
@jiafu1115 jiafu1115 changed the title MINOR: Narrow remote copy lag validator props to Map<String, ?> and Update the upgrade doc for KIP-1241 MINOR: Narrow remote copy lag validator props to Map<String, ?> and update the upgrade doc for KIP-1241 May 24, 2026
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


* The `ClientQuotaCallback#updateClusterMetadata` method is deprecated and will be removed in Kafka 5.0. Custom implementations of `ClientQuotaCallback` no longer need to override this method, as a default no-op implementation is now provided. For further details, please refer to [KIP-1200](https://cwiki.apache.org/confluence/x/axBJFg).
* The in-memory keystores (used for PEM certificates) now use the default type provided by `KeyStore.getDefaultType()` instead of the hardcoded PKCS12 type.
* New configs have been introduced: remote.copy.lag.bytes, remote.copy.lag.ms and their corresponding broker-level configurations. They allow tiered storage redundancy reduced with delayed upload. For further details, please refer to [KIP-1241](https://cwiki.apache.org/confluence/x/A4LMFw).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also addressing this comment #20913 (comment) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 ack
Let me take some time to look into it.
thanks a lot!

@github-actions github-actions Bot removed the triage PRs from the community label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved small Small PRs storage Pull requests that target the storage module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants